New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call FilePatchController methods on the "real item" #1400

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Apr 19, 2018

We're using getRealItem() to identify pane items that are FilePatchControllers, but we're calling FilePatchController methods directly on the pane item even if it isn't a FilePatchController.

Not adding a regression test because StagingView is pending a React port and adding more tests would make it that much more painful 馃槄

Fixes #1396.

@smashwilson smashwilson merged commit 83880df into master Apr 19, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/pending-item branch Apr 19, 2018

smashwilson added a commit that referenced this pull request Apr 19, 2018

Merge pull request #1400 from atom/aw/pending-item
Call FilePatchController methods on the "real item"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment