New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register "github:co-author:..." commands on co-author editor #1411

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Apr 23, 2018

It looks like the command palette doesn't like the github:co-author:...-style commands, but we don't really want these to be user-visible anyway. Let's only register them on the co-author text field to keep them from appearing. They will still appear if you open the command palette with the co-author text field focused, though.

Fixes #1407.

@smashwilson smashwilson merged commit 379bf82 into master Apr 23, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/co-author-author-author-author-author branch Apr 23, 2018

smashwilson added a commit that referenced this pull request Apr 25, 2018

Merge pull request #1411 from atom/aw/co-author-author-author-author-…
…author

Only register "github:co-author:..." commands on co-author editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment