New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIPatterns never match undefined or null #1447

Merged
merged 2 commits into from May 7, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 7, 2018

Untitled pane items respond to getURI but return undefined, which breaks url.parse(). I'm fixing this by making URIPattern always return false for undefined or null URIs.

Fixes #1443.

smashwilson added some commits May 7, 2018

@smashwilson smashwilson merged commit 1ea83a6 into master May 7, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/not-all-panes-have-uris branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment