Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore ability to commit when using Atom with Electron 2.0 #1457
With the current version of the GitHub package, it's not possible to create a commit on macOS when using an Electron 2.0 build of Atom:
And in chat, @smashwilson commented:
It looks like other projects are seeing similar issues with fs-extra 5.0 and newer:
Since the GitHub package only recently upgraded from fs-extra 2.1.2 to 6.0.0 two months ago in #1350 and #1427, it seems like the most expedient remedy is to drop back down to a pre-5.0 version for the time being. This pull request uses fs-extra 4.0.3, which is the highest version in the 4.x series.
This change restores the ability to commit with the GitHub package on Electron 2.0, and it unblocks atom/atom#17273.