New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GitTabController into an Item, Container, and Controller #1458

Merged
merged 13 commits into from May 14, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 11, 2018

The first bit of #1436. Split the GitTabController into three pieces with distinct reponsibilities:

  • GitTabItem implements the "item protocol".
  • GitTabContainer fetches asynchronous properties from the Repository. It manages the git tab's loading state and default properties.
  • GitTabController is left with only the action methods that are passed to the rest of the hierarchy.

This should make fetching mentionable users from GraphQL easier because we can do it within the GitTabContainer and not have yet another layer of "are these props here or not."

smashwilson added some commits May 11, 2018

@smashwilson smashwilson merged commit e37f9fd into master May 14, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/split-controller branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment