New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ListSelection change detection in StagingView #1472

Merged
merged 3 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Member

smashwilson commented May 17, 2018

ListSelection#coalesce() was returning a copied ListSelection even if it didn't actually change any selections. This caused StagingView#componentDidUpdate() to trigger the "selection changed" method even when the selection didn't actually change, which in turn showed the current FilePatchItem.

Another take on #1444. I was actually able to consistently reproduce this and confirm that it was fixed, but I don't know for sure that this is only reason it can happen.

smashwilson added some commits May 17, 2018

@annthurium

This comment has been minimized.

Contributor

annthurium commented May 17, 2018

💯 branch name!

I reviewed this, and didn't catch any issues. Thanks for digging into this.

@smashwilson smashwilson merged commit 32d2299 into master May 17, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/no-seriously-stop-popping-up branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment