New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band-aids for focus management code #1492

Merged
merged 2 commits into from Jun 1, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 30, 2018

Until we can tackle #1403 and improve our approach to remembering focus within the git and GitHub tabs, let's add quick guards against trying to call methods on empty refs.

@smashwilson

This comment has been minimized.

Member

smashwilson commented May 30, 2018

@sguthals would you mind verifying that this fixes #1490 for you?

  1. cd into your atom/github clone
  2. git fetch && git checkout aw/ref-holder
  3. atom-beta -d to open Atom

smashwilson added some commits May 30, 2018

@smashwilson smashwilson merged commit 509ffb7 into master Jun 1, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/ref-holder branch Jun 1, 2018

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1492 from atom/aw/ref-holder
Band-aids for focus management code

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1492 from atom/aw/ref-holder
Band-aids for focus management code

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1492 from atom/aw/ref-holder
Band-aids for focus management code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment