New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward methods from GitTabItem to GitTabController #1495

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 31, 2018

When GitTabController was split into multiple components in #1458, methods on GitTabController that were intended to be called imperatively broke because the ref contained a GitTabItem instead. Let's forward methods to the controller for now.

Fixes an uncaught exception when pressing core:right on a file patch item, likely along with other bugs.

smashwilson added some commits May 31, 2018

@smashwilson smashwilson merged commit 2202c1b into master May 31, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/git-item-forward branch May 31, 2018

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1495 from atom/aw/git-item-forward
Forward methods from GitTabItem to GitTabController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment