New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore getRealItemPromise() #1496

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 31, 2018

Our item proxy was missing a getRealItemPromise() method that some methods in RootController were expecting to be present. Let's implement it.

Fixes #1451.

smashwilson added some commits May 31, 2018

@smashwilson smashwilson merged commit 50900d4 into master May 31, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/get-real-item-promise branch May 31, 2018

smashwilson added a commit that referenced this pull request May 31, 2018

smashwilson added a commit that referenced this pull request May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment