Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC for Issueish List View #1503
I've tried to identify a subset of his vision we could reasonably ship within the next month. My goals here are to rework the GitHub panel to explore an alternate navigation flow (accordion list
Here a slightly different proposal. I'll make first a comment before editing. Note: The "Reviews" are already included just to show how they could be integrated, but they won't be part of this RFC.
1. Preview popover
In order to quickly get a preview with more details about a PR, when clicking on a "Open PRs" list item, a popover shows up:
Clicking on the "Checkout" button...
...checks out that branch. Also the popover closes and the PR list changes to the "Current PR":
It's similar to the popover, but it's more permanent and doesn't disappear when focus moves away. Clicking on "< PRs" at the top, switches back to the PR lists again.
From the popover or "Current PR" sub view, you can click on "Conversation" which opens a center pane with the PR description and timeline that is currently already implemented.
Clicking on the rest (Commits, Checks, Files changed) opens the page on .com for now. In the future they might also open a center pane.
Having the popover AND the "Current PR" sub view would be nice, but it also makes the implementation more complex. Maybe we first should create a simple version to validate if people even find a list of "Open PRs" useful. We can always iterate on it in a next phase.
I am a fan of the "popover with a jump to a full pane" approach - kind of a blend of options (1) and (2) from up above. It's also similar to the way we wrote up the commit detail popup. The only downside is that it isn't a familiar Atom navigation mechanism elsewhere, but I think that's okay.
How would you feel about adding an "open" button to the popup balloon that opens the "full pane item" view of that PR, with the full conversation and the other stuff that's visible in the popup (commit count, status checks, etc)? Maybe we could open it on a double-click on the balloon as well. That would kind of mirror the "pending
Yeah, I was thinking the same thing. But not sure..
What about this:
With a dock item, you could split it to the left and kinda simulate like it would be part of the center pane.
Taking a step back, can you imagine using this proposed PR list? I can think of these scenarios where a PR list would be handy:
And it's meant "As an initial building block toward a pull request review workflow", but I'm not quite sure if I would use the PR list as an entry point when doing a PR review. In most cases, I probably first end up on the PR page on .com and just then decide to review it. The reason is that when getting a notification about a new PR, I either save it to my personal TODO list or just keep the browser tab open. Then whenever I have time, I'll come back to do the review. Other people might have different places where they keep these reminders, like email inbox, project board, but they all have in common that you will click on a link and end up on the PR page on .com. Which brings me to:
It might be worth to make the "I'm looking at a line on .com's diff, I want that same line being open in Atom" as quick and easy as possible? I'll make a separate RFC and we can discuss it there.
ps. I don't mean to say we shouldn't start implementing this RFC, it would be a big improvement over the current version. Just that it would still be a very long way to "I never have to leave Atom" and in the meantime there is a chance to greatly improve the .com <-> Atom workflow.