Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers and Layers and Contexts #1510

Merged
merged 12 commits into from Jun 5, 2018

Conversation

Projects
1 participant
@smashwilson
Copy link
Member

smashwilson commented Jun 5, 2018

Add bridge components to the :atom: MarkerLayer and Marker APIs with React components. My goal is to be able to manipulate markers with a React tree with something like:

render() {
  return (
    <AtomTextEditor>
      <Marker range={[[11, 0], [12, 0]]}>
        <Decoration type='line' className='something' />
        <Decoration type='line-number' className='something-else' />
      </Marker>
      <MarkerLayer>
        <Marker range={[[0, 0], [10, 0]]} invalidate='never' />
        <Marker range={[[20, 0], [25, 6]]} invalidate='never' exclusive={true} />
        <Decoration type='overlay' position='head'>
           <div>
              What's up
           </div>
        </Decoration>
      </MarkerLayer>
    </AtomTextEditor>
  );
}

This will be really useful for implementing #1502.

smashwilson added some commits Jun 5, 2018

@smashwilson smashwilson merged commit e3aa968 into master Jun 5, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/markers-and-layers branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.