Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull Request list #1523
Implement the first part of RFC-002: two lists of pull requests in the GitHub tab, one showing the "current" pull request (if any), and the other showing all pull requests on the chosen remote.
Before + After
GitHub tab: after, on default ref
GitHub tab: after, on unpublished ref
The "current pull request" list displays any pull requests that are associated with the ref that
Special handling also exists for other cases:
A couple things that I think we could improve before
Calling attention to a UI change
When you are on master,
The messaging in the first image above is:
It would be great to get some mock ups where this entire feature would start. As in, what could we imagine is the entry point to the entire pull request experience?
Confirmation of scope of this pr
Finally, just to confirm, this pr scope does not include the following from the rfc yet:
That is totally fine, I just wanted to make sure I wasn't missing that :D
By the way: something that I really wanted to do was, rather than just bolding some text, offer a control that lets you do the thing that we're prompting for. The problem is that we can't currently enter the branch creation flow because it's done with a popup. I'm hoping that we can revisit that after #1370 is accepted.
For a bit of background, I took the messaging verbatim from the old GitHub tab code, which I'd introduced kind of ad-hoc in #1376. Happy to workshop better text with anyone who has ideas for improvements
That's destined for the issueish pane item at the moment, though. The "current pull request" is populated based on
Yeah! That's a great start! @simurai what do you think?
Let's brainstorm just a bit but not let it totally block us today
The messages are now split into two parts:
The "next step" has an icon as a hint.
I tried italic but it doesn't stick out as much:
Since both parts have