Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render markdown flavored emojis in recent commits view. #1532

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
4 participants
@annthurium
Copy link
Contributor

annthurium commented Jun 15, 2018

Before:
screen shot 2018-06-15 at 3 27 12 pm

After:
screen shot 2018-06-15 at 3 26 38 pm

Approach:

I used the package node-emoji because it was updated relatively recently, and small (27.9 kb, or 12.4 kb zipped according to bundephobia).

###Test Plan:

  • manually test that commit titles and text contains emoji
  • manually test that commits that contain colons but no emoji display normally
  • add unit tests for commit titles and commit text that contain emoji

馃崟 馃 鉂わ笍

@annthurium annthurium requested a review from smashwilson Jun 15, 2018

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jun 15, 2018

Nice! I know that the Atom Release Publisher service uses the emojis library to render emojis in commit messages, but I don't know if the results you'd get would be better or worse.

@smashwilson
Copy link
Member

smashwilson left a comment

馃槏 馃寛

@annthurium annthurium merged commit 9c576ce into master Jun 18, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the tt-18-jun-emoji branch Jun 18, 2018

@jasonrudolph

This comment has been minimized.

Copy link
Member

jasonrudolph commented Jun 18, 2018

馃檶 :shipit: 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.