Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top border of the Git panel #1535

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
1 participant
@simurai
Copy link
Member

simurai commented Jun 19, 2018

Description of the Change

This removes the top border on "Unstaged Changes".

screen shot 2018-06-19 at 5 05 02 pm

Alternate Designs

We could try to remove the two empty <div>s at the top, but not quite sure where they are coming from?

screen shot 2018-06-19 at 5 06 25 pm

Benefits

The tab looks more seamless.

Possible Drawbacks

It's less flexible because we assume that "Unstaged Changes" is always shown first, which might change in the future.

Applicable Issues

None

@simurai simurai merged commit d703f20 into master Jun 19, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-fix-top-border branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.