Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill tests for IssueishPaneItem hierarchy #1556

Merged
merged 53 commits into from Jul 3, 2018

Conversation

Projects
2 participants
@smashwilson
Copy link
Member

smashwilson commented Jun 27, 2018

The next part of RFC-002. Add a "Checkout" button to each pull-request backed IssueishPaneItem. When clicked, fetch and checkout the pull request to the active repository.

Remaining
  • Reorganize and rename the IssueishPaneItem hierarchy to match the scheme proposed in #1436.
    • IssueishPaneItem 馃憠 accept a login model as a prop
    • IssueishPaneItemController 馃憠 rename to IssueishDetailContainer; move to lib/controllers/; use shared QueryErrorView and LoadingView components
    • IssueishLookupByNumber 馃憠 rename to IssueishDetailController; move to lib/controllers/ and rename source file
    • IssueishPaneItemView 馃憠 rename to IssueishDetailView; rename source file; move to lib/views/
    • IssueTimelineContainer 馃憠 rename to IssueishTimelineController; rename source file; move to lib/controllers/
    • PrTimelineContainer 馃憠 rename to PrTimelineController; rename source file; move to lib/controllers/
    • PrStatusesContainer 馃憠 rename to PrStatusesView; rename source file; move to lib/views/
    • PrStatusContextContainer "point_right: rename to PrStatusContextView; rename source file; move to lib/views/
    • CommitCommentThreadContainer 馃憠 rename to CommitCommentThreadView; rename source file; move to lib/views/timeline-items
    • CommitCommentContainer 馃憠 rename to CommitCommentView; rename source file; move to lib/views/timeline-items
    • CommitsContainer 馃憠 rename to CommitsView; rename source file; move to lib/views/timeline-items/
    • CommitContainer 馃憠 rename to CommitView; rename source file; move to lib/views/timeline-items/
    • IssueCommentContainer 馃憠 rename to IssueCommentView; rename source file; move to lib/views/timeline-items
    • MergedEventContainer 馃憠 rename to MergedEventView; rename source file; move to lib/views/timeline-items
    • HeadRefForcePushedEventContainer 馃憠 rename to HeadRefForcePushedEventView; rename source file; move to lib/views/timeline-items
    • CrossReferencedEventsContainer 馃憠 rename to CrossReferencedEventsView; rename source file; move to lib/views/timeline-items
    • CrossReferencedEventContainer 馃憠 rename to CrossReferencedEventView; rename source file; move to lib/views/timeline-items
  • Backfill tests for IssueishPaneItem components (go go gadget test coverage 馃搱)
    • IssueishPaneItem
    • IssueishDetailContainer
    • IssueishDetailController
    • IssueishDetailView
    • PrStatusesView
    • PrStatusContextView
    • IssueishTimelineView
    • IssueishBadge
    • GithubDotcomMarkdown
    • CommitCommentThreadView
    • CommitCommentView
    • CommitsView
    • CommitView
    • IssueCommentView
    • MergedEventView
    • HeadRefForcePushedEventView
    • CrossReferencedEventsView
    • CrossReferencedEventView
    • Integration test for "view PR" flow

smashwilson added some commits Jun 27, 2018

smashwilson added some commits Jun 27, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+4.4%) to 77.525% when pulling 7c3c44d on aw/checkout-pull-request into 521d42e on master.

smashwilson added some commits Jun 28, 2018

smashwilson added some commits Jul 2, 2018

@smashwilson smashwilson merged commit 22c07c2 into master Jul 3, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+4.4%) to 77.525%
Details

Feature Sprint: 18 June - 6 July 2018 automation moved this from In progress 馃敡 to Merged 鈽戯笍 Jul 3, 2018

@smashwilson smashwilson deleted the aw/checkout-pull-request branch Jul 3, 2018

@smashwilson smashwilson referenced this pull request Jul 5, 2018

Merged

Checkout Pull Request #1563

23 of 23 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.