Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix uncaught exception when undoing coauthored commit #1558
When undoing a co-authored commit, we were passing a plain object instead of an
smashwilson left a comment
Hmm, taking a look at the coverage data, one notable thing is that it looks like we don't have any tests covering the new co-author form at all. So opening that, cancelling, and confirming a new co-author would be things it would be good to test.
(Er, I see I didn't add any tests for the excluded co-author feature either.
Actually, it looks like we don't have any explicit tests for the co-author feature at all. I'm guessing that's because the bulk of the heavy lifting is done by
I sure hope not
As far as I can tell with a few greps through the codebase:
So I think that means we're fairly safe.
I'm confused - it looks like the form states are tested in
nevermind - I see now that the report is saying we don't have any coverage of the co-author functionality in