Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nightly channel #1561

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@daviwil
Copy link
Member

daviwil commented Jul 3, 2018

Description of the Change

This change adds support for the Atom Nightly release channel to (hopefully! 馃) resolve test failures on Atom Nightly builds. I'm doing this PR against 0.17-releases with the hope of shipping a quick 0.17.1 release as soon as the PR is merged.

Applicable Issues

atom/atom#17538

@daviwil daviwil requested review from smashwilson and annthurium Jul 3, 2018

@annthurium
Copy link
Contributor

annthurium left a comment

looks good to me!

馃殺 :shipit:

@smashwilson
Copy link
Member

smashwilson left a comment

馃憤

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Jul 3, 2018

Thanks all!

@daviwil daviwil merged commit 54416ff into 0.17-releases Jul 3, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@daviwil daviwil deleted the dw-fix-nightly-tests branch Jul 3, 2018

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Jul 3, 2018

I'll ship 0.17.1 and then cherry-pick this commit back into master.

daviwil added a commit that referenced this pull request Jul 3, 2018

Merge pull request #1561 from atom/dw-fix-nightly-tests
Add support for nightly channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.