Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a passwordless temporary keychain on macOS #1574

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
3 participants
@smashwilson
Copy link
Member

smashwilson commented Jul 10, 2018

This might fix #1385.

@smashwilson smashwilson force-pushed the aw/security-binary-tests branch from 16d1e31 to 13888bc Jul 10, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage increased (+0.3%) to 78.127% when pulling 13888bc on aw/security-binary-tests into babf618 on master.

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jul 10, 2018

Okay, I ran ten consecutive rebuilds of this and got a green build every time. I think I actually got it?

name: create and set the default keychain
command: |
security create-keychain -p "" temporary
security default-keychain -s temporary

This comment has been minimized.

@smashwilson

smashwilson Jul 10, 2018

Author Member

@daviwil I bet this would fix our problems on VSTS too 🤔

This comment has been minimized.

@daviwil

daviwil Jul 10, 2018

Member

Sweet! I'll give it a shot today

@smashwilson smashwilson merged commit f3d8570 into master Jul 10, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 78.127%
Details

@smashwilson smashwilson deleted the aw/security-binary-tests branch Jul 10, 2018

daviwil added a commit that referenced this pull request Jul 12, 2018

Merge pull request #1574 from atom/aw/security-binary-tests
Create a passwordless temporary keychain on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.