New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GithubTabController into twos, nay, into threes and fours #1598

Merged
merged 15 commits into from Jul 20, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Jul 19, 2018

Split the GithubTabController out into an Item, a Container, a Controller, and a View. Backfill our test coverage to match.

The next bit of incremental progress toward #1436. Fixes #1594.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 19, 2018

Coverage Status

Coverage increased (+0.1%) to 79.634% when pulling f99b706 on aw/split-github-tab into d2c8283 on master.

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.1%) to 79.634% when pulling f99b706 on aw/split-github-tab into d2c8283 on master.

smashwilson added some commits Jul 20, 2018

@smashwilson smashwilson merged commit cffd0cb into master Jul 20, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 79.634%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 🔧 to Merged ☑️ Jul 20, 2018

@smashwilson smashwilson deleted the aw/split-github-tab branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment