New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessbility linter #1599

Merged
merged 13 commits into from Jul 20, 2018

Conversation

2 participants
@annthurium
Contributor

annthurium commented Jul 20, 2018

This pull requests adds the eslint plugin jsx-a11y so we can lint against common accessbility anti patterns.

Running this plugin with the recommended configuration, there were 84 errors. I think it will be best to fix these incrementally to avoid a sprawling PR with a lot of merge conflicts. Two rules were easily fixable and seemed in scope for this pull request, though:

Images must have alt text
anchor elements must have an href

The only visible styling change is that the RemoteSelectorView now has buttons instead of links. It looks like this:
screen shot 2018-07-20 at 10 04 19 am

@@ -114,6 +115,7 @@ export default class IssueishListView extends React.Component {
}
renderMoreTile() {

This comment has been minimized.

@annthurium

annthurium Jul 20, 2018

Contributor

this is actually a link - we're taking you out of atom and into dotcom. (The other instances I found are really playing the role of a button, though.)

@annthurium

annthurium Jul 20, 2018

Contributor

this is actually a link - we're taking you out of atom and into dotcom. (The other instances I found are really playing the role of a button, though.)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 20, 2018

Coverage Status

Coverage decreased (-0.02%) to 79.505% when pulling 155c21d on tt-18-jul-a11y into c0d5893 on master.

coveralls commented Jul 20, 2018

Coverage Status

Coverage decreased (-0.02%) to 79.505% when pulling 155c21d on tt-18-jul-a11y into c0d5893 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 20, 2018

Coverage Status

Coverage increased (+0.02%) to 79.643% when pulling 886a3fa on tt-18-jul-a11y into dda000d on master.

coveralls commented Jul 20, 2018

Coverage Status

Coverage increased (+0.02%) to 79.643% when pulling 886a3fa on tt-18-jul-a11y into dda000d on master.

@annthurium annthurium merged commit 16eb280 into master Jul 20, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annthurium annthurium deleted the tt-18-jul-a11y branch Jul 20, 2018

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Jul 20, 2018

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment