New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle hovercards II #1601

Merged
merged 4 commits into from Jul 20, 2018

Conversation

2 participants
@simurai
Member

simurai commented Jul 20, 2018

Description of the Change

This changes the issueish tooltips to match the header of the detail panes. Title is at the top, badge at the bottom.

Before After
screen shot 2018-07-20 at 12 05 27 pm screen shot 2018-07-20 at 12 04 48 pm

When clicked, user sees 馃憞 and it should be more familiar.

image

Alternate Designs

Might be nice to also have the CI check in there?

Benefits

  • The tooltip and pane header are more consistent and the user doesn't have to learn a new UI pattern.
  • Tooltips are flexible in width.

Possible Drawbacks

The user name got removed.

Applicable Issues

This is a follow-up to #1593

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 20, 2018

Coverage Status

Coverage increased (+0.05%) to 79.542% when pulling c08f990 on sm/hovercard-2 into 520b11f on master.

coveralls commented Jul 20, 2018

Coverage Status

Coverage increased (+0.05%) to 79.542% when pulling c08f990 on sm/hovercard-2 into 520b11f on master.

@simurai simurai merged commit d2c8283 into master Jul 20, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 79.542%
Details

@simurai simurai deleted the sm/hovercard-2 branch Jul 20, 2018

@smashwilson smashwilson added this to In Progress 馃敡 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Jul 20, 2018

@smashwilson smashwilson moved this from In Progress 馃敡 to Merged 鈽戯笍 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 Jul 20, 2018

This was referenced Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment