New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct integration test flake #1604

Merged
merged 3 commits into from Jul 20, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Jul 20, 2018

Apparently Relay deduced that the Repositories returned by the current pull request and the issueish detail request were the same, but because I wasn't giving them the same ID the second one to arrive was stomping on the first. I think.

smashwilson added some commits Jul 20, 2018

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Jul 20, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 20, 2018

Coverage Status

Coverage increased (+0.009%) to 79.643% when pulling dec0dbb on aw/test-flake into 16eb280 on master.

coveralls commented Jul 20, 2018

Coverage Status

Coverage increased (+0.009%) to 79.643% when pulling dec0dbb on aw/test-flake into 16eb280 on master.

@smashwilson smashwilson merged commit 397e431 into master Jul 20, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 79.643%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 🔧 to Merged ☑️ Jul 20, 2018

@smashwilson smashwilson deleted the aw/test-flake branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment