New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR meta infos #1607

Merged
merged 13 commits into from Aug 9, 2018

Conversation

3 participants
@simurai
Member

simurai commented Jul 23, 2018

Description of the Change

This adds a line (sentence) with more infos and links about the PR.

Before After
screen shot 2018-07-23 at 12 22 18 pm screen shot 2018-07-23 at 12 16 37 pm

TODO

  • Add content
  • Style content
  • Make "2 commits" dynamic
  • Make "3 changed files" dynamic
  • If a PR comes from a fork, add user names. The above screenshot should say atom:master and karevn:issue-17528.

Alternate Designs

There would be many options, here a few alternatives:

screen shot 2018-07-20 at 5 40 26 pm

Benefits

  • Be able to see base and head branch names
  • Be able to single-click to open commits on .com
  • Be able to single-click to open changed files on .com

Possible Drawbacks

More information for the 馃憖 to parse. The more we add, the harder it becomes to find the truly important stuff.

Applicable Issues

Closes #1582

Add PR meta info
Commits, changed files and branch names

annthurium and others added some commits Aug 6, 2018

add commitCount to pull request metadata
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
add changed file count to pull request metadata
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
馃憰
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 9, 2018

Coverage Status

Coverage increased (+0.5%) to 80.13% when pulling 49a4dca on sm/branch-info into 7ecd93a on master.

coveralls commented Aug 9, 2018

Coverage Status

Coverage increased (+0.5%) to 80.13% when pulling 49a4dca on sm/branch-info into 7ecd93a on master.

@annthurium annthurium merged commit 023d776 into master Aug 9, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 80.13%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 馃敡 to Merged 鈽戯笍 Aug 9, 2018

@annthurium annthurium deleted the sm/branch-info branch Aug 9, 2018

This was referenced Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment