Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

PR meta infos #1607

Merged
merged 13 commits into from
Aug 9, 2018
Merged

PR meta infos #1607

merged 13 commits into from
Aug 9, 2018

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 23, 2018

Description of the Change

This adds a line (sentence) with more infos and links about the PR.

Before After
screen shot 2018-07-23 at 12 22 18 pm screen shot 2018-07-23 at 12 16 37 pm

TODO

  • Add content
  • Style content
  • Make "2 commits" dynamic
  • Make "3 changed files" dynamic
  • If a PR comes from a fork, add user names. The above screenshot should say atom:master and karevn:issue-17528.

Alternate Designs

There would be many options, here a few alternatives:

screen shot 2018-07-20 at 5 40 26 pm

Benefits

  • Be able to see base and head branch names
  • Be able to single-click to open commits on .com
  • Be able to single-click to open changed files on .com

Possible Drawbacks

More information for the 👀 to parse. The more we add, the harder it becomes to find the truly important stuff.

Applicable Issues

Closes #1582

Commits, changed files and branch names
Tilde Ann Thurium and others added 6 commits August 6, 2018 16:21
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
@coveralls
Copy link

coveralls commented Aug 9, 2018

Coverage Status

Coverage increased (+0.5%) to 80.13% when pulling 49a4dca on sm/branch-info into 7ecd93a on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants