Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate the git tab on item activation #1629

Merged
merged 5 commits into from Aug 7, 2018

Conversation

3 participants
@smashwilson
Copy link
Member

smashwilson commented Aug 7, 2018

Atom calls a .focus() method on the root DOM element of a pane item's view when it's activated by a mechanism other than a mouse click on a contained element. Register onfocus handlers on our root DOM nodes and propagate these to our components appropriately.

Fixes #1614.

smashwilson added some commits Aug 7, 2018

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Aug 7, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 7, 2018

Coverage Status

Coverage increased (+0.01%) to 79.564% when pulling 39dba4f on aw/no-really-activate into ba5dc66 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 7, 2018

Coverage Status

Coverage increased (+0.1%) to 79.654% when pulling 47236e5 on aw/no-really-activate into ba5dc66 on master.

smashwilson added some commits Aug 7, 2018

@smashwilson smashwilson merged commit 7ecd93a into master Aug 7, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 79.654%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 🔧 to Merged ☑️ Aug 7, 2018

@smashwilson smashwilson deleted the aw/no-really-activate branch Aug 7, 2018

@jasonrudolph

This comment has been minimized.

Copy link
Member

jasonrudolph commented Aug 8, 2018

This was referenced Aug 13, 2018

smashwilson added a commit that referenced this pull request Aug 14, 2018

Merge pull request #1629 from atom/aw/no-really-activate
Activate the git tab on item activation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.