New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow #1647

Merged
merged 4 commits into from Aug 14, 2018

Conversation

Projects
None yet
3 participants
@smashwilson
Member

smashwilson commented Aug 14, 2018

Our workflow has drifted from the way we've documented it somewhat since we're in Editor Tools. Let's bring our markdown up to date with reality 馃挭

smashwilson added some commits Aug 14, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 14, 2018

Coverage Status

Coverage decreased (-0.1%) to 80.12% when pulling f6556a2 on aw/update-workflow into d3bc707 on master.

coveralls commented Aug 14, 2018

Coverage Status

Coverage decreased (-0.1%) to 80.12% when pulling f6556a2 on aw/update-workflow into d3bc707 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 14, 2018

Coverage Status

Coverage decreased (-0.1%) to 80.155% when pulling f24277a on aw/update-workflow into d3bc707 on master.

coveralls commented Aug 14, 2018

Coverage Status

Coverage decreased (-0.1%) to 80.155% when pulling f24277a on aw/update-workflow into d3bc707 on master.

@smashwilson smashwilson requested a review from annthurium Aug 14, 2018

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Aug 14, 2018

Member

@annthurium: Is this super confusing, or does this make sense?

Member

smashwilson commented Aug 14, 2018

@annthurium: Is this super confusing, or does this make sense?

@annthurium

looks good! Thanks for writing up these detailed instructions.

1. _In your atom/github repository:_ run `apm publish preminor` to create the first prerelease version or `apm publish prerelease` to increment an existing prerelease version. Note the generated version number and ensure that it's correct. If the currently deployed version is `v0.19.2`, the first prerelease should be `v0.20.0-0`; if the existing prerelease is `v0.20.0-0`, the next prerelease should be `v0.20.0-1`.
2. _In your atom/atom repository:_ create a new branch and edit `package.json` in its root directory. Change the version of the `"github"` entry beneath `packageDependencies` to match the prerelease you just published.
3. _In your atom/atom repository:_ Run `script/build --install`. This will update Atom's `package-lock.json` files and produce a local development build of Atom with your prerelease version of atom/github bundled.

This comment has been minimized.

@annthurium

annthurium Aug 14, 2018

Contributor

should this be script/build --ci --install?

@annthurium

annthurium Aug 14, 2018

Contributor

should this be script/build --ci --install?

This comment has been minimized.

@smashwilson

smashwilson Aug 14, 2018

Member

Not in this case! --ci can speed up installation substantially, but it only works it package-lock.json is up to date, which it won't be here because we just edited package.json.

If anyone else checks out this atom/atom pull request with the lockfile changes included, then they can add --ci to get a boost to their build time.

@smashwilson

smashwilson Aug 14, 2018

Member

Not in this case! --ci can speed up installation substantially, but it only works it package-lock.json is up to date, which it won't be here because we just edited package.json.

If anyone else checks out this atom/atom pull request with the lockfile changes included, then they can add --ci to get a boost to their build time.

This comment has been minimized.

@annthurium

annthurium Aug 14, 2018

Contributor

ohhhh, that makes sense! Thanks for clarifying.

@annthurium

annthurium Aug 14, 2018

Contributor

ohhhh, that makes sense! Thanks for clarifying.

2. _In your atom/atom repository:_ create a new branch and edit `package.json` in its root directory. Change the version of the `"github"` entry beneath `packageDependencies` to match the prerelease you just published.
3. _In your atom/atom repository:_ Run `script/build --install`. This will update Atom's `package-lock.json` files and produce a local development build of Atom with your prerelease version of atom/github bundled.
* :boom: _If the build fails,_ correct any bugs and begin again at (1) with a new prerelease version.
4. Run `apm uninstall github` and `apm uninstall --dev github` to ensure that you don't have any [locally installed atom/github versions](/CONTRIBUTING.md#living-on-the-edge) that would override the bundled one.

This comment has been minimized.

@annthurium

annthurium Aug 14, 2018

Contributor

I forgot to apm uninstall github yesterday. hmm, maybe that's my problem.

@annthurium

annthurium Aug 14, 2018

Contributor

I forgot to apm uninstall github yesterday. hmm, maybe that's my problem.

This comment has been minimized.

@smashwilson

smashwilson Aug 14, 2018

Member

That shouldn't cause the problem you're seeing. 馃 The risk of not doing this is that you end up testing your linked / git-installed version of atom/github instead of the bundled and snapshotted one we're actually trying to verify.

@smashwilson

smashwilson Aug 14, 2018

Member

That shouldn't cause the problem you're seeing. 馃 The risk of not doing this is that you end up testing your linked / git-installed version of atom/github instead of the bundled and snapshotted one we're actually trying to verify.

@smashwilson smashwilson merged commit 7652f5f into master Aug 14, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 80.155%
Details

@smashwilson smashwilson deleted the aw/update-workflow branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment