New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the Travis build when tests are not passing #1662

Merged
merged 6 commits into from Aug 23, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Aug 23, 2018

Fixes #1661.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 23, 2018

Coverage Status

Coverage decreased (-0.09%) to 80.125% when pulling 4e01be0 on aw/no-travis-its-not-all-ok into dfcfc64 on master.

coveralls commented Aug 23, 2018

Coverage Status

Coverage decreased (-0.09%) to 80.125% when pulling 4e01be0 on aw/no-travis-its-not-all-ok into dfcfc64 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 23, 2018

Coverage Status

Coverage increased (+0.04%) to 80.249% when pulling 69dda30 on aw/no-travis-its-not-all-ok into dfcfc64 on master.

coveralls commented Aug 23, 2018

Coverage Status

Coverage increased (+0.04%) to 80.249% when pulling 69dda30 on aw/no-travis-its-not-all-ok into dfcfc64 on master.

smashwilson added some commits Aug 23, 2018

Revert "Deliberately failing test"
This reverts commit 4e01be0.

@smashwilson smashwilson merged commit 7e62b14 into master Aug 23, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 80.249%
Details

Feature Sprint : 27 August - 14 September 2018 : v0.20.0 automation moved this from In Progress 🔧 to Merged ☑️ Aug 23, 2018

@smashwilson smashwilson deleted the aw/no-travis-its-not-all-ok branch Aug 23, 2018

@smashwilson smashwilson added ci and removed work-in-progress labels Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment