Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip all tests when engines.atom has been bumped to exclude the current Atom version #1664
In #1512, I'm introducing a dependency on functionality that was added to Atom in atom/atom#17736, which is currently only available in nightly or dev builds of Atom. To capture this, I want to be able to bump the semver range specified in the
This adds a check for compatibility between the declared Atom version range and the current host Atom range. If the Atom instance running the test suite is not expected to succeed because it's out of that range, we skip all tests. This will result in a "passing" test suite.
Here we go:
I didn't end up messing with the status or checks APIs to report "you can't deploy to this channel now" after all, though. It would take a moderate amount of work to put in place, we wouldn't be able to see it where we really need it (on the release branches when we're tagging a version!), and it'd be obsolete if we move into atom/atom eventually anyway.
We'll just need to remember which versions of atom/github rely on newer Atom features, by leaving a comment on the Atom ship-ready issue maybe? In any case it hasn't come up that often.
@annthurium what do you think?