New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip all tests when engines.atom has been bumped to exclude the current Atom version #1664

Merged
merged 10 commits into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@smashwilson
Member

smashwilson commented Aug 23, 2018

In #1512, I'm introducing a dependency on functionality that was added to Atom in atom/atom#17736, which is currently only available in nightly or dev builds of Atom. To capture this, I want to be able to bump the semver range specified in the .engines.atom field of our package.json to document the minimum supported Atom version, but our CI matrix rows for stable and beta will fail for everything until that change makes it way to a stable Atom release.

This adds a check for compatibility between the declared Atom version range and the current host Atom range. If the Atom instance running the test suite is not expected to succeed because it's out of that range, we skip all tests. This will result in a "passing" test suite.

smashwilson added some commits Aug 23, 2018

Show outdated Hide outdated test/runner.js Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 23, 2018

Coverage Status

Coverage decreased (-0.05%) to 80.159% when pulling 662d400 on aw/start-your-engines into d2d0200 on master.

coveralls commented Aug 23, 2018

Coverage Status

Coverage decreased (-0.05%) to 80.159% when pulling 662d400 on aw/start-your-engines into d2d0200 on master.

smashwilson added some commits Aug 24, 2018

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Aug 24, 2018

Member

Here we go:

screen shot 2018-08-24 at 9 02 48 am

screen shot 2018-08-24 at 9 03 41 am

screen shot 2018-08-24 at 9 20 16 am

I didn't end up messing with the status or checks APIs to report "you can't deploy to this channel now" after all, though. It would take a moderate amount of work to put in place, we wouldn't be able to see it where we really need it (on the release branches when we're tagging a version!), and it'd be obsolete if we move into atom/atom eventually anyway.

We'll just need to remember which versions of atom/github rely on newer Atom features, by leaving a comment on the Atom ship-ready issue maybe? In any case it hasn't come up that often.

@annthurium what do you think?

Member

smashwilson commented Aug 24, 2018

Here we go:

screen shot 2018-08-24 at 9 02 48 am

screen shot 2018-08-24 at 9 03 41 am

screen shot 2018-08-24 at 9 20 16 am

I didn't end up messing with the status or checks APIs to report "you can't deploy to this channel now" after all, though. It would take a moderate amount of work to put in place, we wouldn't be able to see it where we really need it (on the release branches when we're tagging a version!), and it'd be obsolete if we move into atom/atom eventually anyway.

We'll just need to remember which versions of atom/github rely on newer Atom features, by leaving a comment on the Atom ship-ready issue maybe? In any case it hasn't come up that often.

@annthurium what do you think?

@smashwilson smashwilson requested a review from annthurium Aug 24, 2018

@annthurium

This comment has been minimized.

Show comment
Hide comment
@annthurium

annthurium Aug 24, 2018

Contributor

@smashwilson I'm totally okay with the lower-effort version of this - agree that it hasn't arisen often since usually we can programmatically check for new functionality in atom core.

Contributor

annthurium commented Aug 24, 2018

@smashwilson I'm totally okay with the lower-effort version of this - agree that it hasn't arisen often since usually we can programmatically check for new functionality in atom core.

@smashwilson smashwilson merged commit 71c1781 into master Aug 24, 2018

6 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 80.159%
Details

@smashwilson smashwilson deleted the aw/start-your-engines branch Aug 24, 2018

@smashwilson smashwilson referenced this pull request Aug 28, 2018

Open

Render file patches with a decorated Editor #1512

88 of 92 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment