Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add metrics collection for opening issueish in pane or browser #1694
Description of the Change
There are currently six ways of viewing details for an issueish from our package (at least as far as I can tell... please let me know if you can think of another!). I have instrumented each of them and added a corresponding test.
Added the following events and metadata:
In the process I also caught a bug -- cmd-clicking an issueish link used to throw the following error:
Uncaught TypeError: _issueishDetailItem2.default.opener is not a functionThrown From: [github](https://github.com/atom/github) package 0.19.0 At /Users/kuychaco/.atom/packages/github/lib/views/issueish-link.js:70 TypeError: _issueishDetailItem2.default.opener is not a function at openInNewTab (/packages/github/lib/views/issueish-link.js:70:37) at openIssueishLinkInNewTab (/packages/github/lib/views/issueish-link.js:40:5) at Object.handleClickEvent (/packages/github/lib/views/issueish-link.js:29:5) at BareGithubDotcomMarkdown.handleClick (/packages/github/lib/views/github-dotcom-markdown.js:101:18)
Rather than having separate events for viewing the issueish in a pane or browser, I considered using only one event type of
These changes will shed light on behavior when viewing PR and issue information, potentially inform decisions around product and project work, as well as help us assess the impact of future changes we make.
Here are some questions we might get insight into from collecting these metrics:
None that I can think of...
added this to In Progress 🔧
in Feature Sprint : 27 August - 14 September 2018 : v0.20.0
Sep 18, 2018
thanks for working on this, @kuychaco !
In general, thank you for being so thorough about your unit tests.
I like the extra params you used for
addEvent- it makes it really clear where the user came from and where they're going which should be a boon for our analysts.