New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore diagnostic view files for cache and git timing information #1699

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@kuychaco
Member

kuychaco commented Sep 19, 2018

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

We track code coverage using Coveralls. Some of our files are for diagnostic purposes and don't require tests. This PR excludes these files so that we can get a more accurate sense of how we're doing in terms of code coverage.

Files excluded:

  • lib/views/git-cache-view.js -- for displaying cache diagnostics
  • lib/views/git-timings-view.js -- for displaying git command timings in a waterfall view

Alternate Designs

Not applicable.

Benefits

More accurate test coverage reports. That is, the percentage coverage will convey what we've covered relative to all that we intend/hope to cover.

Possible Drawbacks

None that I can think of.

Applicable Issues

None

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 19, 2018

Coverage Status

Coverage increased (+1.5%) to 81.722% when pulling ec92f98 on ku-coverall-ignore-files into aec3bce on master.

coveralls commented Sep 19, 2018

Coverage Status

Coverage increased (+1.5%) to 81.722% when pulling ec92f98 on ku-coverall-ignore-files into aec3bce on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 19, 2018

Coverage Status

Coverage increased (+1.5%) to 81.722% when pulling ec92f98 on ku-coverall-ignore-files into aec3bce on master.

coveralls commented Sep 19, 2018

Coverage Status

Coverage increased (+1.5%) to 81.722% when pulling ec92f98 on ku-coverall-ignore-files into aec3bce on master.

@annthurium

Thanks for doing this, @kuychaco! I wouldn't have thought to exclude these files but it does make our coverage more accurate.

@kuychaco kuychaco merged commit 60602a2 into master Sep 20, 2018

6 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 81.722%
Details

@kuychaco kuychaco deleted the ku-coverall-ignore-files branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment