Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move "Undo Discard" button behind context menu #1702
Description of the Change
This PR removes the
Note: A similar context menu currently exists in the Merge Conflicts list header for bulk resolve actions.
When multiple files are selected, the context menu item is pluralized to
The Stage/Unstage all buttons no longer disappear when there are no changes. Now they simply become disabled. This gives something for the new kebab menu to sit up against.
Initially, I moved the
This solution still leaves room for the user to accidentally click the
Hiding the undo-discard functionality behind a context menu on the header makes it harder to accidentally trigger this action. See images in section above.
This UX makes it harder to accidentally undo the last discard.
The undo discard functionality might be less discoverable since it is hidden behind a menu. Users may be confused by the disappearance of a button from the UI.
Manual testing steps:
No context menu unit tests added as there is currently no way to write UI tests for context menus in electron --
Added metrics tests for recording the following:
User Experience Research (Optional)
Some light UXR before shipping would be helpful. Especially to assess discoverability.
/cc @simurai for
added this to In Progress 🔧
in Feature Sprint : 27 August - 14 September 2018 : v0.20.0
Sep 25, 2018
The more verbose
An alternative could be the kebab icon
But I think the ellipsis is still better because the icon on the left also has three bars (with bullets).
Something that might be a bit confusing is that:
Should all 3 options be in both menus so that users don't have to think where to find what? The right-click menu would be:
The ellipsis icon menu would be:
referenced this pull request
Oct 3, 2018
I ended up removing the "Stage All" and "Discard All" from the header context menu. Now that we have a dedicated UI element for exposing these actions, it seems unnecessary to have a right-click context menu for the same actions on the header.