New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed merged commit text #1711

Merged
merged 3 commits into from Oct 1, 2018

Conversation

Projects
None yet
5 participants
@MimiDumpling
Contributor

MimiDumpling commented Oct 1, 2018

Description of the Change

Fixed a bug. Made sure that merged commit text is two separate words.

Alternate Designs

n/a

Benefits

Fixes a bug.

Possible Drawbacks

None that I can think of.

Applicable Issues

#1701

Metrics

n/a

Tests

Wrote a unit test to verify that "merged commit" are two separate words. Did manual testing to verify that "merged commit" are two separate words.
screen shot 2018-10-01 at 3 51 23 pm

Documentation

n/a

User Experience Research (Optional)

n/a

MimiDumpling and others added some commits Oct 1, 2018

fixed merged commit text
Co-Authored-By: tilde <annthurium@github.com>
created test for merged commit text
Co-Authored-By: tilde <annthurium@github.com>
👕
Co-Authored-By: tilde <annthurium@github.com>
@annthurium

This comment has been minimized.

Contributor

annthurium commented Oct 1, 2018

nice work @MimiDumpling ! Thanks for fixing this bug.

Code looks good, will merge when the tests pass.

@coveralls

This comment has been minimized.

coveralls commented Oct 1, 2018

Coverage Status

Coverage decreased (-0.07%) to 81.974% when pulling 86ad935 on MimiDumpling:mimi-fix-commit into 46afadd on atom:master.

@annthurium annthurium merged commit 3d99d94 into atom:master Oct 1, 2018

6 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 81.974%
Details
@smashwilson

This comment has been minimized.

Member

smashwilson commented Oct 1, 2018

🎉 Congrats! 🎉

ship-it

@mattr-

This comment has been minimized.

mattr- commented Oct 10, 2018

Awesome! Thank you for fixing this!! ❤️

@annthurium annthurium referenced this pull request Oct 20, 2018

Closed

v0.21.0-0 QA Review #1752

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment