Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed merged commit text #1711
Conversation
MimiDumpling
and others
added some commits
Oct 1, 2018
This comment has been minimized.
This comment has been minimized.
|
nice work @MimiDumpling ! Thanks for fixing this bug. Code looks good, will merge when the tests pass. |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Oct 1, 2018
•
annthurium
merged commit 3d99d94
into
atom:master
Oct 1, 2018
6 checks passed
ci/circleci: beta
Your tests passed on CircleCI!
Details
ci/circleci: dev
Your tests passed on CircleCI!
Details
ci/circleci: stable
Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
coverage/coveralls
Coverage decreased (-0.07%) to 81.974%
Details
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
mattr-
commented
Oct 10, 2018
|
Awesome! Thank you for fixing this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MimiDumpling commentedOct 1, 2018
Description of the Change
Fixed a bug. Made sure that merged commit text is two separate words.
Alternate Designs
n/a
Benefits
Fixes a bug.
Possible Drawbacks
None that I can think of.
Applicable Issues
#1701
Metrics
n/a
Tests
Wrote a unit test to verify that "merged commit" are two separate words. Did manual testing to verify that "merged commit" are two separate words.
Documentation
n/a
User Experience Research (Optional)
n/a