Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keytar to the latest version 馃殌 #1714

merged 2 commits into from Jan 9, 2019


None yet
2 participants
Copy link

greenkeeper bot commented Oct 3, 2018

The dependency keytar was updated from 4.2.1 to 4.3.0.

This version is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

Release Notes for v4.3.0
  • Node 10 and Electron 3.0 support thanks to @shiftkey!

The new version differs by 24 commits.

  • 581c974 4.3.0
  • dcb7416 Merge pull request #126 from atom/add-newer-nodes-for-prebuild
  • 86731a9 upgrade prebuild to latest version
  • f460390 add specific node-abi dependency so we can prebuild against Electron 3
  • abab53b add newer node tags to prebuild scripts
  • e48b67d Merge pull request #119 from atom/bump-to-use-node-10
  • da73b19 use Node 10 on CI for testing and packaging
  • f2d481f Merge pull request #118 from atom/audit-cleanup
  • ea93b40 automated npm audit fix
  • fa18efc Merge pull request #117 from atom/bump-prebuild-again
  • c5927ae some more lockfile updates
  • 84455a0 new prebuild, new life
  • 4447c1a Merge pull request #115 from atom/upgrade-dependencies
  • f35f1cb upgrade prebuild-install to latest version
  • d31e3ff migrate away from deprecated mocha flag

There are 24 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper bot 馃尨

@greenkeeper greenkeeper bot added the greenkeeper label Oct 3, 2018


This comment has been minimized.

Copy link

coveralls commented Oct 3, 2018

Coverage Status

Coverage remained the same at 81.956% when pulling 563d819 on greenkeeper/keytar-4.3.0 into 3d99d94 on master.

greenkeeper[bot] added some commits Oct 3, 2018

@smashwilson smashwilson force-pushed the greenkeeper/keytar-4.3.0 branch from 563d819 to d06eb9f Jan 9, 2019


This comment has been minimized.

Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #1714 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1714      +/-   ##
+ Coverage   91.03%   91.08%   +0.04%     
  Files         185      185              
  Lines       10719    10719              
  Branches     1575     1575              
+ Hits         9758     9763       +5     
+ Misses        961      956       -5
Impacted Files Coverage 螖
lib/git-shell-out-strategy.js 87.52% <0%> (-0.18%) 猬囷笍
lib/controllers/editor-conflict-controller.js 95.95% <0%> (+1.01%) 猬嗭笍
lib/atom/decoration.js 86.74% <0%> (+2.4%) 猬嗭笍
lib/models/conflicts/side.js 96.87% <0%> (+4.68%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f3971dc...d06eb9f. Read the comment docs.

Copy link

smashwilson left a comment


@smashwilson smashwilson merged commit 33a6510 into master Jan 9, 2019

2 checks passed

codecov/patch Coverage not affected when comparing f3971dc...d06eb9f
codecov/project 91.08% (+0.04%) compared to f3971dc

@smashwilson smashwilson deleted the greenkeeper/keytar-4.3.0 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.