New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to catch electron-link and mksnapshot failures #1734

Merged
merged 8 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Member

smashwilson commented Oct 8, 2018

I'm adding a unit test that uses electron-link and electron-mksnapshot to transpile the package source, preprocess it, then snapshot and verify it in a way that's consistent with the way Atom does. This should help us catch snapshotting problems before we tag and publish a release.

It's a bit of a heavy test - it takes about 20s for me on a cold cache. When you're running it locally, the transpilation and electron-link preprocessing are cached from run to run, which helps quite a bit (down to around 7s).

We've hit a fair amount of pain with only discovering snapshot problems when we try to release, so I think it's worth including despite the slowdown. There are alternatives, though: I could extract the snapshot generation into an independent script and add it as an npm run script, so we could choose explicitly when to run it.

@atom/github-package: What do you think?

smashwilson added some commits Oct 7, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented Oct 8, 2018

Oh yuck, AppVeyor is hitting the same problems building native dependencies.

@coveralls

This comment has been minimized.

coveralls commented Oct 8, 2018

Coverage Status

Coverage decreased (-0.009%) to 81.928% when pulling 75e2287 on aw/snapshot-test into 2466c36 on master.

smashwilson added some commits Oct 8, 2018

@smashwilson smashwilson merged commit 5ed66d9 into master Oct 8, 2018

7 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: snapshot Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 81.928%
Details

@smashwilson smashwilson deleted the aw/snapshot-test branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment