Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test to catch electron-link and mksnapshot failures #1734
I'm adding a unit test that uses electron-link and electron-mksnapshot to transpile the package source, preprocess it, then snapshot and verify it in a way that's consistent with the way Atom does. This should help us catch snapshotting problems before we tag and publish a release.
It's a bit of a heavy test - it takes about 20s for me on a cold cache. When you're running it locally, the transpilation and electron-link preprocessing are cached from run to run, which helps quite a bit (down to around 7s).
We've hit a fair amount of pain with only discovering snapshot problems when we try to release, so I think it's worth including despite the slowdown. There are alternatives, though: I could extract the snapshot generation into an independent script and add it as an
@atom/github-package: What do you think?