New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the React devtools installer #1739

Merged
merged 4 commits into from Oct 9, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Oct 9, 2018

Download the React devtools installer ourselves to work around issues using electron-devtools-installer in a renderer process.

Fixes #1738.

smashwilson and others added some commits Oct 9, 2018

Depend on cross-unzip
Co-Authored-By: Katrina Uychaco <katrina@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>
Download React dev tools with fetch() before electron-devtools-installer
Co-Authored-By: Katrina Uychaco <katrina@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>
Display a message when the dev tools are available
Co-Authored-By: Katrina Uychaco <katrina@github.com>
Actually let's use an Atom notification because it's rad
Co-Authored-By: Katrina Uychaco <katrina@github.com>
@coveralls

This comment has been minimized.

coveralls commented Oct 9, 2018

Coverage Status

Coverage decreased (-0.1%) to 81.829% when pulling cc64add on ku-tt-aw/fix-react-devtools-installer into 221cdf5 on master.

@coveralls

This comment has been minimized.

coveralls commented Oct 9, 2018

Coverage Status

Coverage increased (+0.03%) to 81.971% when pulling cc64add on ku-tt-aw/fix-react-devtools-installer into 221cdf5 on master.

@smashwilson smashwilson added this to In Progress 🔧 in Feature Sprint : 1 October - 19 November 2018 : v0.21.0 via automation Oct 9, 2018

@smashwilson smashwilson merged commit 8d0dc05 into master Oct 9, 2018

7 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: snapshot Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 81.829%
Details

Feature Sprint : 1 October - 19 November 2018 : v0.21.0 automation moved this from In Progress 🔧 to Merged ☑️ Oct 9, 2018

@smashwilson smashwilson deleted the ku-tt-aw/fix-react-devtools-installer branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment