New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry known test flakes #1765

Merged
merged 6 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@smashwilson
Member

smashwilson commented Oct 29, 2018

Flag known test flakes with this.retries(5) to limit the pain until we can schedule time to work them down again. Each of these flakes has already been filed with an issue labelled flaky-test.

smashwilson added some commits Oct 29, 2018

@smashwilson smashwilson requested a review from kuychaco Oct 29, 2018

@coveralls

This comment has been minimized.

coveralls commented Oct 29, 2018

Coverage Status

Coverage remained the same at 84.871% when pulling 4826e20 on aw/flag-flakes into 32c39c2 on master.

@kuychaco

👍 lgtm

@smashwilson smashwilson merged commit d21d382 into master Oct 29, 2018

7 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: snapshot Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.871%
Details

@smashwilson smashwilson deleted the aw/flag-flakes branch Oct 29, 2018

@@ -608,6 +608,8 @@ describe('GithubPackage', function() {
let workdirPath2, atomGitRepository2, repository2;
beforeEach(async function() {
this.retries(5); // FLAKE

This comment has been minimized.

@kuychaco

kuychaco Oct 30, 2018

Member

@smashwilson do we actually want this in the beforeEach? Is the goal with this to retry all of the tests in this describe block?

This comment has been minimized.

@smashwilson

smashwilson Oct 30, 2018

Member

My intent was to retry the beforeEach itself if it throws. I was going off of #761 which puts the failure there instead of within any of the specific tests.

I'm... not actually sure if that's what Mocha will do here, though? The documentation doesn't make it clear. It doesn't break though?

@vanessayuenn vanessayuenn referenced this pull request Nov 21, 2018

Closed

v0.23.0-0 QA Review #1806

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment