New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Enzyme and the React adapter #1798

Merged
merged 3 commits into from Nov 15, 2018

Conversation

3 participants
@smashwilson
Member

smashwilson commented Nov 14, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Manually update Enzyme and the Enzyme React 16 adapter to their latest versions.

A while ago, I'd forked the Enzyme React adapter to add support for portals and fragments, which we needed. Since then Enzyme has published a version including that pull request, so we should be able to go back to using the "official" package 馃

Alternate Designs

N/A

Benefits

We'll stay up to date with upstream improvements and fixes.

Possible Drawbacks

We'll inherit regressions I guess?

Applicable Issues

Fixes #1653.
Fixes #1619.

Metrics

N/A

Tests

I'll... run the test suite and see if anything breaks?

Documentation

N/A

User Experience Research

N/A

smashwilson added some commits Nov 14, 2018

@smashwilson smashwilson requested a review from vanessayuenn Nov 14, 2018

@coveralls

This comment has been minimized.

coveralls commented Nov 14, 2018

Coverage Status

Coverage increased (+0.03%) to 84.946% when pulling fa7ef18 on aw/enzyme-update into 33b9063 on master.

@smashwilson smashwilson requested a review from annthurium Nov 14, 2018

Feature Sprint : 1 October - 19 November 2018 : v0.21.0 automation moved this from In Progress 馃敡 to QA Review 馃敩 Nov 15, 2018

@@ -89,7 +89,7 @@ describe('PaneItem', function() {
describe('when opened with a matching URI', function() {
it('calls its render prop', async function() {
let called = false;
shallow(
mount(

This comment has been minimized.

@annthurium

annthurium Nov 15, 2018

Contributor

just out of curiosity...why did we change from shallow to mount here?

This comment has been minimized.

@smashwilson

smashwilson Nov 15, 2018

Member

The test started failing, so I'm guessing there was a change to Enzyme's shallow renderer such that it no longer supports render props the same way. I didn't look into it that hard because just changing it to mount worked.

@smashwilson smashwilson merged commit f16266d into master Nov 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 84.946%
Details

Feature Sprint : 1 October - 19 November 2018 : v0.21.0 automation moved this from QA Review 馃敩 to Merged 鈽戯笍 Nov 15, 2018

@smashwilson smashwilson deleted the aw/enzyme-update branch Nov 15, 2018

@vanessayuenn vanessayuenn referenced this pull request Nov 21, 2018

Closed

v0.23.0-0 QA Review #1806

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment