Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Commit Preview tweaks #1805
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Here some tweaks carried over from #1767 (comment).
1. Tab title
Change the tab title to "Staged Changes".
This makes it the same as the title in the staging view:
2. Move the "See All Staged Changes" button
So that it's part of the "Staged Changes" box.
Note: This is currently just a visual hack. Under the hood, the button is still part of
This is an alternative to #1767.
Less confusion around clicking a "See All Staged Changes" button, but then opening a "Commit Preview" pane.
None, except maybe refactor all occurrences of
Follow-up for #1767.
Documentation is tracked here #1791
User Experience Research (Optional)
I think the change from calling the button "Commit Preview" to "See All Staged Changes" comes from doing some user research. This PR takes it a bit further.
@@ Coverage Diff @@ ## master #1805 +/- ## ========================================== - Coverage 91.15% 91.14% -0.02% ========================================== Files 196 196 Lines 10745 10745 Branches 1575 1575 ========================================== - Hits 9795 9793 -2 - Misses 950 952 +2