Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add button to show/hide password in credentials dialog #1808
Description of the Change
Added a button to the credentials dialog to toggle the input type of the password between
I did this by adding a state variable named
The button has an
As far as I can tell this is the only place in Atom (core) where a
The implementation of the
Currently the button is text-based, alternatively it could be icon-based. However, I did not implement this as the relevant icons are not present/incorrect, see:
Better user experience for users that make typos when entering their credentials, i.e. everyone
No real drawbacks, arguably Shoulder Surfing but as the default still hides the credentials I don't consider this a problem.
I tested the feature using two tests:
Arguably another test verifying the input type when the button was not pressed can be added, I omitted this as the combination of the two tests above imply that assertion.
The GitHub package now provides a button to show/hide the input values of passwords.
User Experience Research (Optional)
No field research was done for this feature, however there is research supporting the addition of this feature. For example NIST specifies that "... [verifiers] SHOULD offer an option to display the secret..."  (where secret refers to the password in this situation).
If desired I can try to find more supporting research.