New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress "Unable to locate git workspace root" error #1809

Merged
merged 1 commit into from Nov 27, 2018

Conversation

4 participants
@Aerijo
Copy link
Contributor

Aerijo commented Nov 26, 2018

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Disables said error from being logged to the console, unless the option reportCannotLocateWorkspaceError is set.

Alternate Designs

Could be brought under gitDiagnostics, but that seemed to be for straight git operations. Probably still fits better there though.

Benefits

Stops polluting the console with errors that aren't actually errors 99% of the time.

Possible Drawbacks

NA. I guess it was / could be useful for debugging an issue, hence leaving it as a togglable option (defaulted to disabled).

Applicable Issues

My headaches.

Metrics

NA

Tests

NA

Documentation

NA. Possibly could though.

Release Notes

  • Suppress "Unable to locate git workspace root" error

User Experience Research (Optional)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage increased (+0.05%) to 85.617% when pulling 5be7bd6 on Aerijo:master into 6e07816 on atom:master.

@smashwilson
Copy link
Member

smashwilson left a comment

👍

I guess it was / could be useful for debugging an issue, hence leaving it as a togglable option (defaulted to disabled).

☝️ If you're curious, this was exactly why the console output was introduced in the first place. We had a crazy bug we couldn't reproduce that manifested as a different exception caught by this try ... catch statement, so I logged it. Of course we haven't seen that problem once since this was introduced 😆

@vanessayuenn
Copy link
Contributor

vanessayuenn left a comment

Thanks for the PR!

@vanessayuenn vanessayuenn merged commit 9fe9fcb into atom:master Nov 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 85.617%
Details

This was referenced Jan 2, 2019

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 Jan 3, 2019

@smashwilson smashwilson referenced this pull request Jan 3, 2019

Closed

v0.23-2 QA Review #1879

16 of 16 tasks complete

smashwilson added a commit that referenced this pull request Jan 4, 2019

Merge pull request #1809 from Aerijo/master
Suppress "Unable to locate git workspace root" error

@smashwilson smashwilson referenced this pull request Jan 4, 2019

Closed

v0.23.2-0 QA Review #1883

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment