Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable the "changes" status from CodeCov #1827
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Disable the "changes" status reported by CodeCov.
I'd originally tried to build us some slack by configuring it with a
It'll unblock pull requests like #1822 that currently have a red "changes" check that we can't do anything about from merging.
It'll also prevent our CI-watching chatops from spamming the #atom channel on every merge to master.
There are some situations where we'll be able to incidentally decrease coverage and still get passing statuses from CodeCov. Deleting tests is one example.
I'm going to see if this pull request doesn't have the "changes" status reported from CodeCov.
User Experience Research (Optional)
added this to In Progress 🔧
in Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0
Dec 6, 2018
I've also removed
Reviewers: how do you feel about this? My intention would be re-enable this if and when we get to a point where our test coverage is stable. I think there are only a few lines that are causing coverage flapping so I don't think that's too far off.
Any idea what lines? Maybe it's worth trying to fix them upfront?
Also, perhaps it's worth reaching out to Codecov support with this question/issue? They seem to be very welcoming of this... they have an "Ask Codecov staff to review reports" section here
Back on Coveralls I consistently saw a few lines in Repository and I think RootController or GithubPackage that would flap coverage. But I don't have a really good way to see which lines they were right now.
I think the changes status is supposed to link to a view that shows them to us once we have a base commit with a coverage report? The page doesn't load for me, though, which probably is worth reaching out to support about.