Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add tab for all changed files in a pull request #1829
Description of the Change
Another step in our quest to march ever onwards towards code review in the editor.
This pull request adds a tab to the pull request pane where we show all changed files associated with a pull request.
Clicking on the "Files" tab displays the full, multi-file diff associated with the pull request> . This is similar to the "Files Changed" tab on dotcom. See design here: https://github.com/atom/github/blob/master/docs/feature-requests/003-pull-request-review.md
When we have support for comments, we will display comments inline in the files view. Comments are out of scope for this pull request, but they're one of the next things we're gonna tackle.
In general, code review in the editor adds a non trivial amount complexity to the UI, which is only justified for users that use GitHub pull request reviews.
This pull request adds a tab to the pull request pane in the GitHub package, that shows all changed files in a pull request.
User Experience Research (Optional)