New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build PRs that only change documentation #1843

Merged
merged 1 commit into from Dec 13, 2018

Conversation

2 participants
@smashwilson
Copy link
Member

smashwilson commented Dec 13, 2018

When I was first setting up Azure DevOps, I was trying to be all clever and kept builds from triggering on docs-only changes. Unfortunately, our expected status checks don't account for this, so docs-only PRs will never be marked mergeable; see #1842.

@smashwilson smashwilson added the ci label Dec 13, 2018

@smashwilson smashwilson requested a review from vanessayuenn Dec 13, 2018

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from In Progress 🔧 to QA Review 🔬 Dec 13, 2018

@vanessayuenn
Copy link
Contributor

vanessayuenn left a comment

good catch!

@smashwilson smashwilson merged commit 18a4f21 into master Dec 13, 2018

2 checks passed

codecov/patch Coverage not affected when comparing 01206e1...7c7400d
Details
codecov/project 90.71% remains the same compared to 01206e1
Details

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from QA Review 🔬 to Merged ☑️ Dec 13, 2018

@smashwilson smashwilson deleted the aw/build-doc-changes branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment