New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin codecov package to the lastest master #1845

Merged
merged 7 commits into from Dec 14, 2018

Conversation

2 participants
@smashwilson
Copy link
Member

smashwilson commented Dec 14, 2018

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Upgrade the codecov package to the lastest commit on master to take advantage of codecov/codecov-node#114, which should report additional build metadata (like the PR number) from Azure DevOps builds. I'm hopeful that this will make the coverage report a bit more useful.

Alternate Designs

I could also fork the package and publish it under @smashwilson like I did for the test runner. This is slightly less effort though, and this way Greenkeeper will let us know when the next upstream release happens.

Benefits

Poking around the CodeCov UI, it looks like coverage reports submitted as pull requests have slightly different functionality than the builds we've been seeing:

screen shot 2018-12-14 at 8 34 20 am

I'm particularly intrigued by the "changes" tab there.

I bet this will let us re-enable the changes build status for PR builds that I turned off in #1827 (for pull requests). It might also open the way for coverage change comments.

Possible Drawbacks

It'll take slightly longer to install. It's also a bit messy to depend on git SHAs. But hopefully that's temporary.

Applicable Issues

n/a

Metrics

n/a

Tests

If this uploads correctly, I might add tests for something we don't currently cover to see what the coverage deltas look like.

Documentation

n/a

Release Notes

n/a

User Experience Research (Optional)

"Do we, the developers, understand the coverage reports better" 馃槈

@smashwilson smashwilson added the ci label Dec 14, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1845 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
+ Coverage   90.74%   90.85%   +0.11%     
==========================================
  Files         195      195              
  Lines       10729    10727       -2     
  Branches     1570     1570              
==========================================
+ Hits         9736     9746      +10     
+ Misses        993      981      -12
Impacted Files Coverage 螖
lib/models/repository-states/present.js 95.02% <酶> (+1.72%) 猬嗭笍
lib/atom/decoration.js 84.33% <100%> (-0.19%) 猬囷笍
lib/atom/atom-text-editor.js 98% <100%> (-0.04%) 猬囷笍
lib/git-shell-out-strategy.js 87.7% <0%> (+0.53%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 91f31db...e5b50b3. Read the comment docs.

smashwilson added some commits Dec 14, 2018

@smashwilson smashwilson requested a review from atom/github-package Dec 14, 2018

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from In Progress 馃敡 to QA Review 馃敩 Dec 14, 2018

@annthurium
Copy link
Contributor

annthurium left a comment

yay thanks!! Looking forward to improved coverage reports.

Also thanks for backfilling that test coverage.

@smashwilson smashwilson merged commit a10a8b3 into master Dec 14, 2018

2 checks passed

codecov/patch 100% of diff hit (target 90.74%)
Details
codecov/project 90.85% (+0.11%) compared to 91f31db
Details

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from QA Review 馃敩 to Merged 鈽戯笍 Dec 14, 2018

@smashwilson smashwilson deleted the aw/codecov-pin branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment