New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove status section from feature proposal template #1849

Merged
merged 1 commit into from Dec 18, 2018

Conversation

2 participants
@vanessayuenn
Copy link
Contributor

vanessayuenn commented Dec 18, 2018

I notice we have been inconsistent at remembering to change the status of feature requests from proposed to accepted when we merge the feature, and I don't think the status conveys much important information.


View rendered docs/feature-requests/000-template.md

@vanessayuenn vanessayuenn requested a review from atom/github-package Dec 18, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #1849 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.01%     
==========================================
  Files         195      195              
  Lines       10727    10727              
  Branches     1570     1570              
==========================================
- Hits         9746     9745       -1     
- Misses        981      982       +1
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 87.52% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755132b...56cf3ae. Read the comment docs.

@smashwilson
Copy link
Member

smashwilson left a comment

👍 Good call.

@vanessayuenn vanessayuenn merged commit a2376e9 into master Dec 18, 2018

2 checks passed

codecov/patch Coverage not affected when comparing 755132b...56cf3ae
Details
codecov/project 90.84% (-0.01%) compared to 755132b
Details

@vanessayuenn vanessayuenn deleted the vanessayuenn-patch-1 branch Dec 18, 2018

This was referenced Jan 2, 2019

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 Jan 3, 2019

@smashwilson smashwilson referenced this pull request Jan 3, 2019

Closed

v0.23-2 QA Review #1879

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment