New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle renames on file changed tab #1854

Merged
merged 2 commits into from Dec 19, 2018

Conversation

2 participants
@vanessayuenn
Copy link
Contributor

vanessayuenn commented Dec 19, 2018

image

Now that renaming files is properly handled in the upstream library, we should add support for that on files changed tab too. Now the title for a renamed file is rendered as $oldPath → $newPath. Fixes #1852.

@vanessayuenn vanessayuenn requested a review from atom/github-package Dec 19, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #1854 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
- Coverage   91.15%   91.13%   -0.02%     
==========================================
  Files         196      196              
  Lines       10738    10744       +6     
  Branches     1574     1575       +1     
==========================================
+ Hits         9788     9792       +4     
- Misses        950      952       +2
Impacted Files Coverage Δ
lib/views/multi-file-patch-view.js 100% <ø> (ø) ⬆️
lib/views/file-patch-header-view.js 100% <100%> (ø) ⬆️
lib/github-package.js 68.09% <0%> (-0.39%) ⬇️
lib/git-shell-out-strategy.js 87.52% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66faaf9...0772a05. Read the comment docs.

@smashwilson
Copy link
Member

smashwilson left a comment

👍 Nice

@vanessayuenn vanessayuenn merged commit 278e871 into master Dec 19, 2018

2 checks passed

codecov/patch 100% of diff hit (target 91.15%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +8.84% compared to 66faaf9
Details

This was referenced Jan 2, 2019

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 Jan 3, 2019

@smashwilson smashwilson referenced this pull request Jan 3, 2019

Closed

v0.23-2 QA Review #1879

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment