Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fetch and display readonly inline comments. #1856
Description of the Change
Another step in our quest to march ever onwards towards code review in the editor.
This pull request adds readonly comments to pull request pane, that are displayed inline with the diff.
The GitHub package now shows readonly inline comments in the pull request view.
User Experience Research (Optional)
We have a user experience research script for the GitHub pane and the pull request view, that will help us understand how the information we're displaying is or is not useful to our users. We intend to resume user research in January, after the holidays.
@@ Coverage Diff @@ ## master #1856 +/- ## ========================================== - Coverage 91.09% 91.01% -0.09% ========================================== Files 185 189 +4 Lines 10719 10835 +116 Branches 1575 1592 +17 ========================================== + Hits 9765 9861 +96 - Misses 954 974 +20
moved this from In Progress 🔧
to QA Review 🔬
in Sprint : 9 January 2019 - 12 February 2019 : v0.25.0
Jan 9, 2019
smashwilson left a comment
The only blocker I see is an unresolved TODO from and for myself