Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
UserStore handles GitHub remotes that no longer exist #1869
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Break from the user accumulation loop in
When you have no GitHub remotes at all, we currently fall back to your local git history to populate the UserStore. Given that we now have the possibility that your GitHub remote could no longer exist, it may make sense to fall back to that in the instance that no valid GitHub remotes are found any more. I opted not to go that route in this take to keep the change small and minimize risk.
A stacktrace on package activation no longer occurs.
If you delete all GitHub repositories referenced by your git remotes - or add a bunch of fake ones - your UserStore will stay empty.
I've added a unit test to capture the null-Repository case to verify the fix.
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #1869 +/- ## ======================================= Coverage 91.14% 91.14% ======================================= Files 196 196 Lines 10745 10745 Branches 1575 1575 ======================================= Hits 9794 9794 Misses 951 951