New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the "show more" button a left margin #1877

Merged
merged 1 commit into from Jan 3, 2019

Conversation

2 participants
@smashwilson
Copy link
Member

smashwilson commented Jan 3, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Give the "show more" button a left margin so that it doesn't look smooshed against the commit message:

before

Alternate Designs

N/A

Benefits

after

Possible Drawbacks

N/A

Applicable Issues

Fixes #1874.

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@smashwilson smashwilson added the design label Jan 3, 2019

@smashwilson smashwilson requested a review from atom/github-package Jan 3, 2019

@smashwilson smashwilson moved this from In Progress 🔧 to QA Review 🔬 in Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 Jan 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         196      196           
  Lines       10745    10745           
  Branches     1574     1574           
=======================================
  Hits         9803     9803           
  Misses        942      942
Impacted Files Coverage Δ
lib/github-package.js 68.09% <0%> (-0.39%) ⬇️
lib/git-shell-out-strategy.js 87.87% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eab9c...9b61d09. Read the comment docs.

@smashwilson smashwilson merged commit 1439973 into master Jan 3, 2019

2 checks passed

codecov/patch Coverage not affected when comparing b7eab9c...9b61d09
Details
codecov/project 91.23% remains the same compared to b7eab9c
Details

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from QA Review 🔬 to Merged ☑️ Jan 3, 2019

@smashwilson smashwilson deleted the aw/show-more-spacing branch Jan 3, 2019

@smashwilson smashwilson referenced this pull request Jan 3, 2019

Closed

v0.23-2 QA Review #1879

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment