New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make title texts in PR details tabs not selectable #1878

Merged
merged 1 commit into from Jan 3, 2019

Conversation

2 participants
@vanessayuenn
Copy link
Contributor

vanessayuenn commented Jan 3, 2019

resolves #1873

@vanessayuenn vanessayuenn requested a review from atom/github-package Jan 3, 2019

@smashwilson
Copy link
Member

smashwilson left a comment

shiiiip

(It took me longer to find this .gif than it did to review the PR)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1878 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1878   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         196      196           
  Lines       10745    10745           
  Branches     1574     1574           
=======================================
  Hits         9803     9803           
  Misses        942      942

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eab9c...358efdc. Read the comment docs.

@vanessayuenn vanessayuenn merged commit 84389e8 into master Jan 3, 2019

2 checks passed

codecov/patch Coverage not affected when comparing b7eab9c...358efdc
Details
codecov/project 91.23% remains the same compared to b7eab9c
Details

Stability Sprint : 20 November 2018 - 8 January 2019 : v0.24.0 automation moved this from In Progress 🔧 to Merged ☑️ Jan 3, 2019

@vanessayuenn vanessayuenn deleted the PR-tabs-selectable branch Jan 3, 2019

@smashwilson smashwilson referenced this pull request Jan 3, 2019

Closed

v0.23-2 QA Review #1879

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment