Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest react and react-dom #1884

Merged
merged 2 commits into from Jan 8, 2019

Conversation

2 participants
@smashwilson
Copy link
Member

smashwilson commented Jan 4, 2019

Now that atom/electron-link#15 is out, we should be able to update to the latest React builds without hitting weird snapshotting errors or silently falling back to ancient browser shims.

Fixes #1832.

@smashwilson smashwilson added this to In Progress 🔧 in Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 via automation Jan 4, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1884 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   91.22%   91.24%   +0.01%     
==========================================
  Files         196      196              
  Lines       10745    10745              
  Branches     1574     1574              
==========================================
+ Hits         9802     9804       +2     
+ Misses        943      941       -2
Impacted Files Coverage Δ
lib/atom/decoration.js 85.54% <0%> (+1.2%) ⬆️
lib/atom/gutter.js 92.3% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391514c...b21a9e7. Read the comment docs.

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jan 4, 2019

Oh, right, this probably needs #1885.

@annthurium
Copy link
Contributor

annthurium left a comment

do we need to do any manual testing? Or are you pretty confident that the newest versions of these libs aren't gonna break anything??

also, is this the version with hooks??

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jan 4, 2019

do we need to do any manual testing? Or are you pretty confident that the newest versions of these libs aren't gonna break anything??

For React, yeah, I was going to at least take it for a spin and make sure it runs. Our tests should catch anything that regressed, but just to be sure.

also, is this the version with hooks??

lol

screen shot 2019-01-04 at 6 21 23 pm

@smashwilson smashwilson requested a review from atom/github-package Jan 8, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jan 8, 2019

I fired it up and clicking around a bit and it looks like we're still good 👌

Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 automation moved this from In Progress 🔧 to QA Review 🔬 Jan 8, 2019

@annthurium
Copy link
Contributor

annthurium left a comment

cool, let's ship it! Thanks for doing the manual testing.

@smashwilson smashwilson merged commit 58a6f13 into master Jan 8, 2019

2 checks passed

codecov/patch Coverage not affected when comparing 391514c...b21a9e7
Details
codecov/project 91.24% (+0.01%) compared to 391514c
Details

Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 automation moved this from QA Review 🔬 to Merged ☑️ Jan 8, 2019

@smashwilson smashwilson deleted the aw/react-up branch Jan 8, 2019

@kuychaco kuychaco referenced this pull request Feb 4, 2019

Closed

v0.25.0-0 QA Review #1936

14 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.